Fix IllegalArgumentException with duplicate natures#2184
Merged
merks merged 1 commit intoeclipse-platform:masterfrom Oct 3, 2025
Merged
Fix IllegalArgumentException with duplicate natures#2184merks merged 1 commit intoeclipse-platform:masterfrom
merks merged 1 commit intoeclipse-platform:masterfrom
Conversation
Changed ProjectDescription.hasPrivateChanges() to use HashSet instead of Set.of() to handle duplicate natures gracefully. Set.of() throws IllegalArgumentException on duplicates, but HashSet tolerates them and correctly compares nature sets. Also added test case testDuplicateNatures() to ensure this regression doesn't occur again.
Contributor
Author
|
ECA check failure is due: and currently unavoidable, I plan to merge anyways if build succeeds here as it is the same solution that was suggested by @merks and its more a technical detail. If there will be ever concerns regarding AI generated content, the only new thing is the test what then can be deleted without any problem. |
Contributor
Contributor
|
The content is simple, follows the original suggestion of mine in the issue, and the test case is mechanical in nature. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed ProjectDescription.hasPrivateChanges() to use HashSet instead of Set.of() to handle duplicate natures gracefully. Set.of() throws IllegalArgumentException on duplicates, but HashSet tolerates them and correctly compares nature sets.
Also added test case testDuplicateNatures() to ensure this regression doesn't occur again.
Derived from here: